Subject: Re: [vserver] Kernel compile warnings
From: Herbert Poetzl <herbert@13thfloor.at>
Date: Thu, 21 Dec 2017 22:34:32 +0100

On Thu, Dec 21, 2017 at 09:36:54PM +0100, Tor Rune Skoglund wrote:
> Hi List,

Hey Tor Rune,

> When compiling a 4.1.43 kernel with the latest patch
> (patch-4.1.42-vs2.3.8.6.diff) with gcc6.4.0 it show some code warnings.
> (See below. ) It probably does not matter (I don't know), but I thought
> I at least should mentioned it in case someone or Herbert care.

can you check with patch-4.1.48-vs2.3.8.6.diff on 4.1.48?

Thanks,
Herbert

http://vserver.13thfloor.at/Experimental/patch-4.1.48-vs2.3.8.6.diff

> BR,
> Tor Rune Skoglund

>   CC      kernel/vserver/proc.o
> kernel/vserver/proc.c: In function 'proc_xid_iterate':
> kernel/vserver/proc.c:620:43: warning: comparison of constant '0' with
> boolean expression is always false [-Wbool-compare]
>    if (!dir_emit(ctx, ".", 1, ino, DT_DIR) < 0)
>                                            ^
> kernel/vserver/proc.c:626:44: warning: comparison of constant '0' with
> boolean expression is always false [-Wbool-compare]
>    if (!dir_emit(ctx, "..", 2, ino, DT_DIR) < 0)
>                                             ^
> kernel/vserver/proc.c: In function 'proc_nid_iterate':
> kernel/vserver/proc.c:701:43: warning: comparison of constant '0' with
> boolean expression is always false [-Wbool-compare]
>    if (!dir_emit(ctx, ".", 1, ino, DT_DIR) < 0)
>                                            ^
> kernel/vserver/proc.c:707:44: warning: comparison of constant '0' with
> boolean expression is always false [-Wbool-compare]
>    if (!dir_emit(ctx, "..", 2, ino, DT_DIR) < 0)
>                                             ^
> kernel/vserver/proc.c: In function 'proc_virtual_iterate':
> kernel/vserver/proc.c:854:43: warning: comparison of constant '0' with
> boolean expression is always false [-Wbool-compare]
>    if (!dir_emit(ctx, ".", 1, ino, DT_DIR) < 0)
>                                            ^
> kernel/vserver/proc.c:860:44: warning: comparison of constant '0' with
> boolean expression is always false [-Wbool-compare]
>    if (!dir_emit(ctx, "..", 2, ino, DT_DIR) < 0)
>                                             ^
> kernel/vserver/proc.c: In function 'proc_virtnet_iterate':
> kernel/vserver/proc.c:935:43: warning: comparison of constant '0' with
> boolean expression is always false [-Wbool-compare]
>    if (!dir_emit(ctx, ".", 1, ino, DT_DIR) < 0)
>                                            ^
> kernel/vserver/proc.c:941:44: warning: comparison of constant '0' with
> boolean expression is always false [-Wbool-compare]
>    if (!dir_emit(ctx, "..", 2, ino, DT_DIR) < 0)
>                                             ^
>   LD      kernel/vserver/vserver.o