Subject: Re: [vserver] Re: Testing patch 3.0.9-vs2.3.2
From: Corey Wright <undefined@pobox.com>
Date: Sun, 20 Nov 2011 21:44:36 -0600
Sun, 20 Nov 2011 21:44:36 -0600
On Sun, 20 Nov 2011 22:30:32 +0100
Sebastian Steinhuber <sebastian.steinhuber@googlemail.com> wrote:

> Hi!
> 
> Am 18.11.2011 03:32, schrieb Herbert Poetzl:
> > issue should be fixed in vs2.3.2.1, no need to upload
> > your .config anymore ...
> 
> Tested 3.0.9-vs2.3.2.1 and 3.1.1-vs2.3.2.1, they are running fine.
> Thanks to all for your work. I am glad that you decided to develop for
> recent kernel versions that support recent hardware.
> 
> However, the kernel 3.0.9-vs2.3.2.1 prints messages of the form
> Nov 19 21:40:45 opc64 kernel: [   26.249117] 1,0 0,0
> Nov 19 21:40:45 opc64 kernel: [   26.249449] 1,0 0,0
> Nov 19 21:40:45 opc64 kernel: [   26.251259] 1,0 0,0
> Nov 19 21:40:45 opc64 kernel: [   26.252936] 1,1 104,104
> Nov 19 21:40:45 opc64 kernel: [   26.252960] 1,1 104,104
> Nov 19 21:40:45 opc64 kernel: [   26.252966] 1,1 104,104
> continuously, at least four per second, flooding syslog.
> 
> I don't have an idea of what these messages mean

the message means herbert wanted to see the values used in an if conditional
immediately before the if conditional was executed (ie standard debugging
practice).

the attached patch should remove the debug code.  i haven't had a chance to
test (build & execute) it yet, but i'm pretty confident it works (as it's a
single printk removal).

and i checked 3.1.1-vs2.3.2.1 and that printk statement doesn't exist (nor
any of the vxdprintk()s in 3.0.9-vs2.3.2.1's kernel/ptrace.c).

thanks for noticing the problem as i had executed the kernel (in virtualbox),
but never paid attention to the syslog (or dmesg).

corey
--
undefined@pobox.com

> 3.0.7-vs2.3.1 is quiet.
> I also tested a 3.0.9 kernel compilation without the 2.3.2.1 patch,
> which also is quiet as usual.
> I append the config file for your information.
> Thanks in advance for your consideration.
> 
> Best,
> Sebastian





--- linux-3.0.9-vs2.3.2.1/kernel/ptrace.c.orig	2011-11-20 21:19:35.000000000 -0600
+++ linux-3.0.9-vs2.3.2.1/kernel/ptrace.c	2011-11-20 21:30:07.000000000 -0600
@@ -186,11 +186,6 @@ ok:
 	vxdprintk(VXD_CBIT(perm, 8),
 		"__ptrace_may_access(%p) check ok", task);
 
-	printk("%d,%d %d,%d\n",
-		vx_check(task->xid, VS_IDENT),
-		task_vx_flags(task, VXF_STATE_ADMIN, 0),
-		current->xid, task->xid);
-
 	if (!vx_check(task->xid, VS_IDENT) &&
 		!task_vx_flags(task, VXF_STATE_ADMIN, 0))
 		return -EACCES;