Subject: VServer for 2.6.32
From: Ben Hutchings <ben@decadent.org.uk>
Date: Tue, 12 Jul 2011 03:02:42 +0100
Tue, 12 Jul 2011 03:02:42 +0100
I'm a member of the Debian kernel team, not specifically interested in
VServer but looking at it as part of the maintenance of our current
stable release (Debian 6.0 'squeeze').

I see there's a new VServer version (vs2.3.0.36.29.7) based on stable
release 2.6.32.41.  This is appreciated, and I'm intending to update our
VServer packages accordingly.

However, after comparing this with the previous version
(vs2.3.0.36.29.6) I noticed this change:

> diff --git a/kernel/ptrace.c b/kernel/ptrace.c
> index ca81fce..c140532 100644
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -627,10 +627,6 @@ SYSCALL DEFINE4(ptrace, long, request, long, pid, long, addr,
long, data)
>  		goto out;
>  	}
>  
> -	ret = -EPERM;
> -	if (!vx check(vx task xid(child), VS WATCH P | VS IDENT))
> -		goto out put task struct;
> -
>  	if (request == PTRACE ATTACH) {
>  		ret = ptrace attach(child);
>  		/*

Was this removal intentional?  Was this check redundant with those in
  ptrace may access()?

Secondly, following commit 3c77f845722158206a7209c45ccddc264d19319c
which was backported into 2.6.32.37, you need to make the new
acct arg size() function call vx vmpages add().  Patch for this is
attached.

Finally, I couldn't find changelogs for VServer patches.  Where can I
find this information?

Ben.

-- 
Ben Hutchings
It is easier to write an incorrect program than to understand a correct one.


["application/pgp-signature" not shown]