Subject: Re: [vserver] hashify
From:Sandino Araico Sánchez <sandino@sandino.net>
Date: Tue, 20 Mar 2018 15:03:30 -0600
Tue, 20 Mar 2018 15:03:30 -0600
On 18/03/18 10:10, Tor Rune Skoglund wrote:
>
> If nothing is there in the code today to handle such issues, what is
> the right way to deal with it:
>
> 1) Don't care, as any problems arising from any possibly broken in-vm
> hardlinks are so rare that side-effects of it "never" happens?
>
> 2) Patch the vhashify code so that files that are already hardlinks
> inside a vm will not be hashified? (As suggested above)
>
> 3) Patch the CoW code so that it handles files that was originally
> hardlinked in the vm to be restored as hardlinked also when CoW does
> its work?
>
Patch de CoW code so that it breaks the hard link only when the
hard-linked other file is outside the VM. Hard links inside the VM
should be preserved as such.
>
> 4) Don't use hashify?
>
> What do you suggest? Anyone with any experiences to share?
>
> BR, Tor Rune Skoglund, trs@swi.no
>
>

-- 
Sandino Araico Sánchez 
http://sandino.net



On 18/03/18 10:10, Tor Rune Skoglund wrote:

If nothing is there in the code today to handle such issues, what is the right way to deal with it:

1) Don't care, as any problems arising from any possibly broken in-vm hardlinks are so rare that side-effects of it "never" happens?

2) Patch the vhashify code so that files that are already hardlinks inside a vm will not be hashified? (As suggested above)

3) Patch the CoW code so that it handles files that was originally hardlinked in the vm to be restored as hardlinked also when CoW does its work?

Patch de CoW code so that it breaks the hard link only when the hard-linked other file is outside the VM. Hard links inside the VM should be preserved as such.

4) Don't use hashify?

What do you suggest? Anyone with any experiences to share?

BR, Tor Rune Skoglund, trs@swi.no



-- 
Sandino Araico Sánchez 
http://sandino.net