Subject: Re: [vserver] Linux 3.13.1 Patch for Testing ...
From: Arkadiusz Miśkiewicz <arekm@maven.pl>
Date: Sat, 1 Feb 2014 09:31:07 +0100

 Sat, 1 Feb 2014 09:31:07 +0100
On Saturday 01 of February 2014, Herbert Poetzl wrote:

> Back to positive thinking and good news: a first patch [2]
> for 3.13.1 is now available for testing, please let me
> know if you encounter any issues or hit any specific
> problems with it.

Fails to build here with PID namespace enabled. Upstream change:

commit c2b1df2eb42978073ec27c99cc199d20ae48b849
Author: Andy Lutomirski <luto@amacapital.net>
Date:   Thu Aug 22 11:39:16 2013 -0700

    Rename nsproxy.pid ns to nsproxy.pid ns for children
    
    nsproxy.pid ns is *not* the task's pid namespace.  The name should clarify
    that.
    
    This makes it more obvious that setns on a pid namespace is weird --
    it won't change the pid namespace shown in procfs.


so some verification if vs was using this correctly is probably sensible. If 
it was then rename should be enough.

  CC [M]  sound/core/seq/seq timer.o
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c: 
In function 'vs mix nsproxy':
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:150:20:

error: 'struct nsproxy' has no member named 'pid ns'
   old pid = nsproxy->pid ns;
                    ^
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:151:10:

error: 'struct nsproxy' has no member named 'pid ns'
   nsproxy->pid ns = new nsproxy->pid ns;
          ^
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:151:32:

error: 'struct nsproxy' has no member named 'pid ns'
   nsproxy->pid ns = new nsproxy->pid ns;
                                ^
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:152:14:

error: 'struct nsproxy' has no member named 'pid ns'
   if (nsproxy->pid ns)
              ^
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/kernel/vserver/space.c:153:22:

error: 'struct nsproxy' has no member named 'pid ns'
    get pid ns(nsproxy->pid ns);
                      ^
  CC      arch/x86/kernel/sysfb efi.o
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/scripts/Makefile.build:308: 
recipe for target 'kernel/vserver/space.o' failed
make[4]: *** [kernel/vserver/space.o] Error 1
/home/users/arekm/rpm/BUILD/kernel-3.13.1/linux-3.13/scripts/Makefile.build:455: 
recipe for target 'kernel/vserver' failed
make[3]: *** [kernel/vserver] Error 2
make[3]: *** Waiting for unfinished jobs....

-- 
Arkadiusz Miśkiewicz, arekm / maven.pl