Subject: Re: [vserver] Testing patch 3.0.9-vs2.3.2
From: Corey Wright <undefined@pobox.com>
Date: Thu, 17 Nov 2011 19:35:29 -0600
Thu, 17 Nov 2011 19:35:29 -0600
On Thu, 17 Nov 2011 14:24:19 +0100
Sebastian Steinhuber <sebastian.steinhuber@googlemail.com> wrote:

> But the compilation of 3.0.9-vs2.3.2 stopped with errors. The full
> output of 'make all' is appended to the message.
> 
> include/linux/vserver/limit_int.h: In function '__vx_acc_cres':
> include/linux/vserver/limit_int.h:16:1: error: 'vs_debug_cres'
> undeclared (first use in this function)
> include/linux/vserver/limit_int.h:16:1: note: each undeclared identifier
> is reported only once for each function it appears in
> include/linux/vserver/limit_int.h: In function '__vx_add_cres':
> include/linux/vserver/limit_int.h:33:1: error: 'vs_debug_cres'
> undeclared (first use in this function)
> include/linux/vserver/limit_int.h: In function '__vx_cres_avail':
> include/linux/vserver/limit_int.h:84:1: error: 'vs_debug_limit'
> undeclared (first use in this function)
> make[2]: *** [arch/x86/mm/init.o] Fehler 1
> make[1]: *** [arch/x86/mm] Fehler 2
> make: *** [arch/x86] Fehler 2
> 
> I'm guessing that there might be a bug. I'm on x86-64, debian/unstable
> with patches from http://vserver.13thfloor.at/Experimental/. Any hints?
> Thanks in advance.

the compilation errors go away with the attached patch.

i've tested the patch by:
 * successfully compiled the kernel with VSERVER_DEBUG not set
 * successfully executed testme.sh and testfs.sh on the kernel

see the conversation between bertl and undefined in the irc log [1] for more
information.

[1] http://irc.13thfloor.at/LOG/2011-11/LOG_2011-11-17.txt

> Best regards,
> Sebastian

corey
--
undefined@pobox.com


--- linux-3.0.9-vs2.3.2/include/linux/vserver/debug.h.orig	2011-11-17 09:50:23.000000000
-0600
+++ linux-3.0.9-vs2.3.2/include/linux/vserver/debug.h	2011-11-17 14:08:43.000000000
-0600
@@ -80,7 +80,6 @@ void dump_vx_info_inactive(int);
 
 #else	/* CONFIG_VSERVER_DEBUG */
 
-/*
 #define vs_debug_switch 0
 #define vs_debug_xid	0
 #define vs_debug_nid	0
@@ -90,7 +89,6 @@ void dump_vx_info_inactive(int);
 #define vs_debug_cres	0
 #define vs_debug_dlim	0
 #define vs_debug_cvirt	0
-*/
 
 #define vxdprintk(x...) do { } while (0)
 #define vxlprintk(x...) do { } while (0)